Fix Windows wheel version by moving swig into cibuildwheel#37
Merged
Conversation
Running swig in the "Prepare for Windows" step dirtied the git working tree (regenerating tracked mykytea_wrap.cxx), causing setuptools-scm to produce a dev version instead of the tag version. Move swig to CIBW_BEFORE_BUILD_WINDOWS so it runs in cibuildwheel's copy of the project. Also add skip-existing to PyPI publish for safe re-uploads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running swig in the "Prepare for Windows" step dirtied the git working tree (regenerating tracked mykytea_wrap.cxx), causing setuptools-scm to produce a dev version instead of the tag version. Move swig to CIBW_BEFORE_BUILD_WINDOWS so it runs in cibuildwheel's copy of the project.
Also add skip-existing to PyPI publish for safe re-uploads.